You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds initial support to RTE for running a medium-range lagged ensemble forecast, including multiprocessing. Currently the lagged ensemble workflow's optional args open_loop_state and closed_loop_state are not used by RTE and must be empty parts of the --lagged-ensemble CLI arg. Support for these can be added later.
The lagged ensemble is treated as a medium_range forcing configuration type, and each member is a separate call to run_forecast.py or run_default.py
This should be reviewed in conjunction with related PRs on other repositories:
Update: For run_forecast.py calls to lagged ensemble, the development branches of nwm-msw-mgr and nwm-fcst-mgr may be used. The above non-development branches are only needed for run_default.py calls to lagged ensemble at this time.
Note for reviewers and testers: you will also need to pull the latest ngen-forcingdevelopment branch, to have the updated forcing configuration files available to be mounted at runtime.
@cosumi-rtx if looking to test the lagged ensemble members through run_forecast.py aka run_fcst.sh, i.e. for a realtime forecast of a gage that already has its dependencies met (already has a calibration result) then I believe the "forecast" workflow will currently work with development branches of nwm-msw-mgr and nwm-fcst-mgr. I just tested this and the realizations did start. I did not let them run to completion.
Though if wanting to run the "default" workflow (run_default.py aka run_default.sh`) methods of lagged ensemble members, where there is no dependency on a preexisting calibration result, then non-development branches mentioned in earlier comments of this PR are needed currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial support to RTE for running a medium-range lagged ensemble forecast, including multiprocessing. Currently the lagged ensemble workflow's optional args
open_loop_stateandclosed_loop_stateare not used by RTE and must be empty parts of the--lagged-ensembleCLI arg. Support for these can be added later.The lagged ensemble is treated as a
medium_rangeforcing configuration type, and each member is a separate call torun_forecast.pyorrun_default.pyThis should be reviewed in conjunction with related PRs on other repositories:
NGWPC/nwm-msw-mgr#54(already merged)NGWPC/nwm-fcst-mgr#18(closed)NGWPC/ngen-forcing#138(already merged)nwm-fcst-mgrbranch: https://github.com/NGWPC/nwm-fcst-mgr/tree/jwade_NGWPC-10211_wcossnwm-msw-mgrbranch: https://github.com/NGWPC/nwm-msw-mgr/tree/jwade_NGWPC-10183_update_fcstUpdate: For
run_forecast.pycalls to lagged ensemble, thedevelopmentbranches ofnwm-msw-mgrandnwm-fcst-mgrmay be used. The above non-developmentbranches are only needed forrun_default.pycalls to lagged ensemble at this time.